search

CORE-POS / IS4C

Cooperative Operational Retail Environment
http://www.core-pos.com
GNU General Public License v2.0
63 stars 44 forks source link

Remove `maknz/slack` requirement #1186

Closed lgedgar closed 1 year ago

lgedgar commented 1 year ago

must install separately if needed

It's not a show-stopper for me if this needs to stay in, but kinda seemed like it could come out. In practice it's keeping us with older guzzlehttp/guzzle - which I discovered in #1185. The maknz/slack lib (1.7.0) requires guzzle 0.6 but latest is 0.7 - I worked around by supporting either in rattail/posterior.

The slack requirement was added in https://github.com/CORE-POS/IS4C/commit/52220f112528e30c3aa127f72e55d7b480a1017f but IIUC this would only come up if someone used the IncidentTracker plugin?

gohanman commented 1 year ago

That's fine. We've migrated this to Teams anyway. I'll strip out the Slack support for now. It's pretty trivial to redo if someone ever wants it.

lgedgar commented 1 year ago

Thanks, FYI for real-world example:

After pulling latest CORE from upstream, then in my Poser demo I ran composer update which dropped the maknz/slack package and gave me newer guzzlehttp/guzzle package as expected. I then committed new lock file.