search

CORE-POS / IS4C

Cooperative Operational Retail Environment
http://www.core-pos.com
GNU General Public License v2.0
63 stars 44 forks source link

Phone column size mismatch #1197

Closed lgedgar closed 11 months ago

lgedgar commented 11 months ago

There is a mismatch of sorts between schema for meminfo.phone (30 chars) and Customers.phone (20 chars).

The ContactInfo module limits the text input to 30 chars. (Specifically I'm looking at the "Alt. Phone" field here.)

I noticed this problem when using the webservices API, which (I think) always interacts with both customer schemas. In the real world, I used API to "get" a member record which had a full 30-char value for alt phone, and it returned the 30-char value. But when I tried to "post" the same data back to API, it failed.

In my one example so far, a reasonable fix is to edit the customer in question and be done with it. But then I'd like to add a 20-char limit on the text input to avoid it in the future. Or perhaps better is to grow Customers.phone to 30 chars? Both seem simple enough but latter would require schema upgrade.

Happy to submit a PR but thought I should feel it out first. See also #882 for previous related background esp. since my real-world involved alt phone?

gohanman commented 11 months ago

In general when a character limit comes up, I think unless there's a concrete, practical reason to impose a limit it might as well expand out to 255. And I don't see any particular reason for a low cap here.