search

COSIMA / access-om3

ACCESS-OM3 global ocean-sea ice-wave coupled model
13 stars 7 forks source link

Rename `CORE_IAF_JRA55do` datm `datamode` #219

Closed dougiesquire closed 1 month ago

dougiesquire commented 3 months ago

We should probably rename the CORE_IAF_JRA55do datm datamode - see @aekiss's comment here

which is confusing, because CORE is a different dataset from JRA55do, and also the same stream names are also used for the RYF configs.

This will also require changes to all our configs to update the datamode in datm_in - e.g. here.

dougiesquire commented 3 months ago

This change has now been merged, but let's leave this issue open until we've released the changes and updated the configs

aekiss commented 2 months ago

Can somebody build this version so we can complete https://github.com/ACCESS-NRI/access-om3-configs/pull/123? I'm not sure how to go about it.

aekiss commented 2 months ago

I built access-om3 in /scratch/v45/aek156/build/access-om3/Release using build.sh, but I don't know how to build it and put it in /g/data/ik11/spack/0.21.2/modules/access-om3/0.x.0/linux-rocky8-cascadelake (which is what I want for the config.yaml update in https://github.com/ACCESS-NRI/access-om3-configs/pull/123) - is that documented somewhere?

ezhilsabareesh8 commented 2 months ago

@aekiss Even I built using build.sh, but I asked Micael for guidance on how to build it in /g/data/ik11/spack/0.21.2/modules/access-om3/0.x.0/linux-rocky8-cascadelake. I'm still awaiting his response.

dougiesquire commented 2 months ago

It's not really documented anywhere unfortunately, but hopefully this is the last time we do this with the ik11 spack environment. I can do a new development build later today.

anton-seaice commented 2 months ago

There are some instructions for the cosima spack here:

https://github.com/COSIMA/spack-config/blob/0.21.2/README.md

I'm sure they need refinement, but its not totally undocumented :)

aekiss commented 2 months ago

Thanks @anton-seaice, I've now added a link to that in the wiki https://github.com/COSIMA/access-om3/wiki/Building

dougiesquire commented 2 months ago

Sorry for the delay, but this is done now.

$ module use /g/data/ik11/spack/0.21.2/modules/access-om3/0.x.0/linux-rocky8-cascadelake
$ module load access-om3/96f91599f746b4866bbd3f05ee6eb192ba70d391_main

Configs will obviously need to be updated accordingly.

aekiss commented 2 months ago

Awesome, thanks @dougiesquire! Nothing to apologise for - aren't you on leave?

aekiss commented 2 months ago

Any objections if we do the config updates via https://github.com/ACCESS-NRI/access-om3-configs/pull/123? That issue needs to update datm.streams.xml, which is done via an updated generation script that uses the new datamode name, making these issues interdependent.

anton-seaice commented 2 months ago

As long as its clear in the commits what is going on (and no squash merging) thats ok by me :)

aekiss commented 2 months ago

I think we'll want to avoid squash merges as we'll need to do some detailed cherry-picking for the various configs.

anton-seaice commented 1 month ago

Closed through access-om3-configs:

dev-1deg_ryf https://github.com/ACCESS-NRI/access-om3-configs/pull/123 dev-1deg_iaf https://github.com/ACCESS-NRI/access-om3-configs/pull/130 dev-1deg_ryf_wombatlite https://github.com/ACCESS-NRI/access-om3-configs/pull/125 dev-025deg_ryf

https://github.com/ACCESS-NRI/access-om3-configs/pull/126

access-om3-wav-configs:

dev-1deg_ryf https://github.com/ACCESS-NRI/access-om3-wav-configs/pull/52 dev-1deg_iaf https://github.com/ACCESS-NRI/access-om3-wav-configs/pull/53

Noting there are other issues with runoff (e.g. https://github.com/COSIMA/access-om3/issues/231)