search

COSIMA / cosima-cookbook

Framework for indexing and querying ocean-sea ice model output.
https://cosima-recipes.readthedocs.io/en/latest/
Apache License 2.0
58 stars 25 forks source link

Pin sqlalchemy<2.0 #331

Closed dougiesquire closed 1 year ago

dougiesquire commented 1 year ago

The cosima-cookbook doesn't work with sqlalchemy 2 - see #320. This PR pins sqlalchemy to < 2.0.

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (5fb8ae1) 54.94% compared to head (fe298bd) 54.94%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #331 +/- ## ======================================= Coverage 54.94% 54.94% ======================================= Files 22 22 Lines 1811 1811 ======================================= Hits 995 995 Misses 816 816 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

micaeljtoliveira commented 1 year ago

@dougiesquire Will we try to support v2 at some point? Or we assume intake is the future? Just asking because the corresponding issue should be left open if the answer to the first question is yes. In any case, fine with me pinning the version, either temporarily or permanently.

dougiesquire commented 1 year ago

Hmmm I don't know. I have no intention to update to v2, but someone else might want to? You're right that the issue should probably be left open. I've changed that now.