search

COVID-19-electronic-health-system / Corona-tracker

An easy-to-use PWA to monitor the user's wellness and learn about COVID-19.
https://coronatracker.me/
MIT License
235 stars 101 forks source link

Add CODEOWNERS #612

Closed acthelemann closed 4 years ago

acthelemann commented 4 years ago

Adds a CODEOWNERS file for the /client/ directory.

acthelemann commented 4 years ago

Just added the branch protection rules, so you'll see this PR needs two approving reviewers.

Admins can merge anyway, not sure if we want to allow that or not.

SomeMoosery commented 4 years ago

I would say let's keep admins as allowed to merge, just in case something accidentally breaks and we need to do a quick hotfix.

If it's not the case already I'd say we should just make you Adham and I admins for the time being (on mobile so hard to check myself). Do you think that'd be fine?

acthelemann commented 4 years ago

Yeah, I believe owners in the organization are admins by default. We are all owners.

https://github.com/orgs/COVID-19-electronic-health-system/people?query=role%3Aowner

acthelemann commented 4 years ago

Any other people you think should be code owners? I'm not too familiar with other people

SomeMoosery commented 4 years ago

I would also vote to add @pavel-ilin for this repo, thinking in terms of who contributes most often and for the longest amount of time.

We can expand the list as we continue 👍

AdhamAH commented 4 years ago

I almost dropped my laptop!😅 I think I pressed by mistake the merge! I don't know what to say😂

acthelemann commented 4 years ago

Haha should be fine