restructuring show me more

[AdhamAH]

⚠️ IMPORTANT: Please do not create a Pull Request without creating an issue first.

All changes need to be discusssed before proceeding. Failure to do so may result in the pull request being rejected.

Please be sure to review our Code of Conduct, Contributing Guidelines, and Support documentation before submitting a pull request.

---

Please include the issue number the pull request fixes by replacing YOUR-ISSUE-HERE in the text below.

Fixes #591 and Fixes #590

Summary

restructuring show me more

Details

1- Followed the advice of @acthelemann to use ExpansionPanel for the observations 2- deleted unused files 3- updated some styles around the app to fit changes 4- removed bootstrap

Test Plan (required)

Final Checklist

• [x] For CoronaTracker, did you bump the version in package.json?
  • Update the second decimal for a major change
  • Update the third decimal for a minor change
  • Numbers can go past 9, e.g. 1.0.9 => 1.0.10
  • For more info, read about Semantic Versioning
• [ ] Did you add any new tests as necessary?
• [x] Is your PR rebased off the most current master?
• [x] Have you squashed all commits? (can be done at merge)
• [x] Did you use yarn not npm? (important!)
• [x] Did you use Material-UI wherever possible?
• [x] Did you run yarn lint on the code?
• [x] Did you run all of your most recent changes locally to make sure everything is working?

[AdhamAH]

Will do the changes @SomeMoosery first I needed to make sure the rebase worked and it did

[acthelemann]

@AdhamAH I can't run this locally because observations.jsx is lowercase

[AdhamAH]

I changed it before pushing! I am not sure why it didn't change here

[acthelemann]

I'm not 100% sure if these changes broke the WeeklyTrackerDay component swiping

[SomeMoosery]

Yeah, I'm having issues too locally, without checking out this branch.

Last person to edit implementation of WeeklyTrackerDay is @Bellex0 here - but that seems like too long ago to have gone unnoticed. This should probably made into a bug report though, which I can make

[AdhamAH]

I just tried it too, it was there before these changes, so I will rebase again and we will open a separate issue for that? @SomeMoosery

[acthelemann]

Yeah, that should be a separate issue, but the question that that issue, and this PR, is dependent on remains: Do we want it to be swipeable? If yes, what do we want it to do? Go to "Show Me More" with just that observation showing?

[SomeMoosery]

I'm personally on board with removing the swipe functionality and making it clickable, as people have been complaining about swiping on a web app (since not a native app). Would that fall under this issue though or should we open a new one?

[acthelemann]

I'm personally on board with removing the swipe functionality and making it clickable, as people have been complaining about swiping on a web app (since not a native app). Would that fall under this issue though or should we open a new one?

That would also be a separate issue, but I'm asking if we want the click/swipe handling in the first place. If we do, then we'll need that detailData.length ? detailData : observations line from before that only displays the one observation in the "Show Me More" screen

[AdhamAH]

That was my intention to keep things as before So do you want me to put it back? @acthelemann @SomeMoosery

[SomeMoosery]

Oh, okay, I see - sorry for causing confusion. Yes, let's put that back. I wasn't even suggesting we remove it originally, was just asking what purpose it served