PhurbaSherpa commented 4 years ago

⚠️ IMPORTANT: Please do not create a Pull Request without creating an issue first.

All changes need to be discusssed before proceeding. Failure to do so may result in the pull request being rejected.

Please be sure to review our Code of Conduct, Contributing Guidelines, and Support documentation before submitting a pull request.

Please include the issue number the pull request fixes by replacing YOUR-ISSUE-HERE in the text below.

Fixes #668

Gives a user a reminder every time they log in to take their survey if they haven't taken one that day.

If a user deletes their data they'll be reminded to take a survey upon going back to the health Log.

Before a user was forced to take a survey if they haven't that day before being able to navigate the website.

reminder

[x] For CoronaTracker, did you bump the version in package.json?
- Update the second decimal for a major change
- Update the third decimal for a minor change
- Numbers can go past 9, e.g. 1.0.9 => 1.0.10
- For more info, read about Semantic Versioning
[x] Did you add any new tests as necessary?
[x] Is your PR rebased off the most current master?
[x] Have you squashed all commits? (can be done at merge)
[x] Did you use yarn not npm? (important!)
[x] Did you use Material-UI wherever possible?
[x] Did you run yarn lint on the code?
[x] Did you run all of your most recent changes locally to make sure everything is working?

AdhamAH commented 4 years ago

I looked a little bit farther into it. It does work but I needed to refresh. not sure yet why

PhurbaSherpa commented 4 years ago

I looked a little bit farther into it. It does work but I needed to refresh. not sure yet why

I noticed I set surveyPage to zero in the clearSurvey action instead of setting it to surveyPage 1, just fixed it

SomeMoosery commented 4 years ago

Just need an approval from @AdhamAH as he requested changes and this should be good to go