COVID-19-electronic-health-system / Corona-tracker

An easy-to-use PWA to monitor the user's wellness and learn about COVID-19.
https://coronatracker.me/
MIT License
235 stars 101 forks source link

added nlp tokenizer to python gsheet pull script #691

Closed ngiangre closed 4 years ago

ngiangre commented 4 years ago

⚠️ IMPORTANT: Please do not create a Pull Request without creating an Issue first.

All changes need to be discussed before proceeding. Failure to do so may result in the pull request being rejected.

Before submitting a pull request, please be sure to review:


Please include the issue number the pull request fixes by replacing YOUR-ISSUE-HERE in the text below.

Fixes #YOUR-ISSUE-HERE

Summary

This is in reference to #665

This PR submits a python script for the mvp which pulls the gsheet content for translations and formats them accurately.

The translation.json files are added to the client/[language]/ folders.

Details

Test Plan (required)

Final Checklist

acthelemann commented 4 years ago

A basic readme on a general overview of what this does and how to run it in src/python would be helpful

ngiangre commented 4 years ago

you're totally right @acthelemann these are great suggestions and should be made. I can make another issue for this - as a feature enhancement. I think we need to move to the next step of working with these translations so the front end devs can try to use it. Getting feedback should be prioritized if since we'll most likely need to change functions/methods from that as well.