COVID-19-electronic-health-system / Corona-tracker

An easy-to-use PWA to monitor the user's wellness and learn about COVID-19.
https://coronatracker.me/
MIT License
235 stars 101 forks source link

[BUG] Incorrectly formatted travis.yml file #692

Closed whoabuddy closed 4 years ago

whoabuddy commented 4 years ago

⚠️ IMPORTANT: Please fill out this template to give us as much information as possible to address the issue.

Prerequisites

Description of the Bug/Issue

During the TravisCI build I noticed some commands that were not running correctly in the logs. Sometimes the features will still build successfully, but there is some cleanup to do here.

Steps to Reproduce

  1. Push a commit
  2. View TravisCI build logs
  3. See errors below

Expected Behavior

I expected the commands listed in travis.yml to run sequentially.

Actual Behavior

Based on the config here:

language: node_js

node_js:
  "stable"

cache:
  directories:
   node_modules

before_install:
  npm -g install yarn
  npm install -g jest-dom
  npm install -g react-scripts
  cd client
  yarn

before_script:
  cd client
  yarn

script:
  yarn test
  yarn run build

The commands are lumped together, see:

$ npm -g install yarn npm install -g jest-dom npm install -g react-scripts cd client yarn
$ cd client yarn
$ yarn test yarn run build

and

Ran all test suites matching /yarn|run|build/i.
The command "yarn test yarn run build" exited with 0.

Reproduces How Often

100% (can be seen in both failed and passing entries)

Additional Information

I will submit a PR following this issue with my proposed changes based on the Travis CI documentation.