COVID-19-electronic-health-system / Corona-tracker

An easy-to-use PWA to monitor the user's wellness and learn about COVID-19.
https://coronatracker.me/
MIT License
235 stars 101 forks source link

Organize client folder & refactor NavBar & Fix i18 text #720

Closed AdhamAH closed 4 years ago

AdhamAH commented 4 years ago

⚠️ IMPORTANT: Please do not create a Pull Request without creating an Issue first.

All changes need to be discussed before proceeding. Failure to do so may result in the pull request being rejected.

Before submitting a pull request, please be sure to review:


Please include the issue number the pull request fixes by replacing YOUR-ISSUE-HERE in the text below.

Fixes #709 fixes #719 fixes #715

Summary

  1. refactor NavBar.jsx
  2. reorganize client folder

Details

Test Plan (required)

Screenshot 2020-05-17 at 01 07 42

Screenshot 2020-05-17 at 00 22 04 Screenshot 2020-05-17 at 00 23 29 Screenshot 2020-05-17 at 01 05 57 Screenshot 2020-05-17 at 01 06 41

Final Checklist

AdhamAH commented 4 years ago

Thank you! Yeah I saw the issue you made after I opened #719 😄 It is a close issue but it is different. What I did here not made the changes in #716 but I changed what component the NavBar uses to something more suitable to make the changes to UI and NavBar easier to apply.

SomeMoosery commented 4 years ago

While this all looks good and it should be ready to merge, I'd like to get one more codeowner approval on this before merging in (@acthelemann @pavel-ilin)

Otherwise, i'll just merge it tomorrow though as we should really get this in

AdhamAH commented 4 years ago

No worries at all @SomeMoosery I actually could merge it before I went to sleep but I didn't. I was waiting for the two other PR to merge. It is easier for me to rebase, hopefully 😄