Closed AdhamAH closed 4 years ago
Thank you! Yeah I saw the issue you made after I opened #719 😄 It is a close issue but it is different. What I did here not made the changes in #716 but I changed what component the NavBar uses to something more suitable to make the changes to UI and NavBar easier to apply.
While this all looks good and it should be ready to merge, I'd like to get one more codeowner approval on this before merging in (@acthelemann @pavel-ilin)
Otherwise, i'll just merge it tomorrow though as we should really get this in
No worries at all @SomeMoosery I actually could merge it before I went to sleep but I didn't. I was waiting for the two other PR to merge. It is easier for me to rebase, hopefully 😄
⚠️ IMPORTANT: Please do not create a Pull Request without creating an Issue first.
All changes need to be discussed before proceeding. Failure to do so may result in the pull request being rejected.
Before submitting a pull request, please be sure to review:
Please include the issue number the pull request fixes by replacing YOUR-ISSUE-HERE in the text below.
Fixes #709 fixes #719 fixes #715
Summary
client
folderDetails
Test Plan (required)
Final Checklist
package.json
?1.0.9
=>1.0.10
yarn
notnpm
? (important!)yarn lint
on the code?