search

CPJKU / partitura

A python package for handling modern staff notation of music
https://partitura.readthedocs.io
Apache License 2.0
250 stars 18 forks source link

Test File paths Indexing is ambiguous #305

Open manoskary opened 1 year ago

manoskary commented 1 year ago

Hello, with this issue I would like to address the way the partitura tests are handled. This issue doesn't actually concern the partitura package code but only the test handling. We've been using pre-defined paths in the tests init and indexing the files that correspond to the actual file we would like to test for each one of the unit-tests. However, adding or removing test example files can perturb this indexing and moreover, we don't always know what file we are running the test on. I propose we change all the unit-tests with another solution to remove the indices, maybe calling the files by name would be a better option.

fosfrancesco commented 1 year ago

I'm in favour of just using the local path to the file. It will make things much easier. However, we need to find a solution for the tests that run on a larger set of scores, like the load_score test. Maybe in the test init we can have a function which takes all the files divided by folder.

manoskary commented 1 year ago

It will take some time, but maybe we can start fixing it for the next release (1.3.3)

github-actions[bot] commented 8 months ago

This issue had no activity for 6 months. It will be closed in 2 weeks unless there is some new activity. Is this issue already resolved?

github-actions[bot] commented 2 months ago

This issue had no activity for 6 months. It will be closed in 2 weeks unless there is some new activity. Is this issue already resolved?

manoskary commented 2 months ago

Is not yet resolved, leaving it open for future reference.