search

CS-SI / eodag-labextension

Jupyterlab extension for EODAG search
Apache License 2.0
18 stars 2 forks source link

missing jupyter-labextension on install #2

Closed sbrunato closed 3 years ago

sbrunato commented 3 years ago

Following the readme :

Setup

pip install .
jupyter labextension install .

the last command returns:

Exception: Jupyter command `jupyter-labextension` not found.

jupyterlab may be needed in install_requires instead of extras_require?

sbrunato commented 3 years ago

In GitLab by @ctriquet-cs on Apr 1, 2021, 15:27

assigned to @PhML

sbrunato commented 3 years ago

In GitLab by @PhML on Apr 6, 2021, 13:41

In https://github.com/jupyterlab/extension-examples all examples use install_requires:

hello-world/setup.py

    install_requires=[
        "jupyterlab>=3.0.0rc15,==3.*",
    ],

So I think it is the way to do.

sbrunato commented 3 years ago

In GitLab by @ctriquet-cs on Apr 6, 2021, 17:14

@PhML ok to move jupyterlab into install_requires.

sbrunato commented 3 years ago

In GitLab by @PhML on Apr 28, 2021, 07:42

mentioned in merge request !4 f48de63fb5a3a3c37ecace55317c412d08e2ad89