search

CSC207-2022F-UofT / course-project-bill-gates

A bill recording software developed by team "Bill Gates."
9 stars 4 forks source link

[+] Change color function [+] Change font function #34

Closed eevadai closed 1 year ago

eevadai commented 1 year ago

[+] Change color function [+] Change font function

Lei-Tin commented 1 year ago

I helped you remove .DS_Store from your branch!

Lei-Tin commented 1 year ago

Nice work! 👍

After playing around with the setting, I found out a few problems

  1. image

    There is a space here that doesn't really align well?

  2. The settings window pops out on the top left corner of the monitor, maybe we can try to initialize the window at the center of the screen.

  3. After setting up the preferences we like, the "background color" and "font" re-initializes to the default of the application instead of keeping the settings that we originally had.

For example, if I changed the background color to "Red" and the font to "Times New Roman". If I would like to edit the settings again, I would probably want to keep the current settings and adjust from the settings.

  1. After closing the settings menu either using the "X", "Confirm", or "Cancel", it seems like the menu bar's setting is still being pressed, hence, I cannot click on settings again. In order to open the settings menu again, I would need to click elsewhere aside from the settings button to reset the state of the settings button, then I can press on it again.

I will do code review later this week, but maybe @ScottCTD can also handle that for me. PS: Seems like the settings window is not working normally for Scott in his Windows PC.

image
CharlotteChenyy commented 1 year ago

In addition to the review above, there are another two problems:

  1. As ray mentioned, there's a problem with your settingsMenu's state

After closing the settings menu either using the "X", "Confirm", or "Cancel", it seems like the menu bar's setting is still being pressed, hence, I cannot click on settings again. In order to open the settings menu again, I would need to click elsewhere aside from the settings button to reset the state of the settings button, then I can press on it again.

  1. There's a problem with your Cancel button. For example, assume that I have already set a different color and font for our GUI first. And then, if I click the Cancel button when I try to reset it to another color, our GUI will immediately back to its default settings instead of our previous settings.

The video below shows both of the problems:

https://user-images.githubusercontent.com/60980117/203691494-f6749888-b376-4008-b372-520614f8a98c.mp4