search

CSC207-2022F-UofT / course-project-bill-gates

A bill recording software developed by team "Bill Gates."
9 stars 4 forks source link

[*] Update interface and abstract class viewmodel #38

Closed Yuhan-Ut closed 1 year ago

Yuhan-Ut commented 1 year ago

make an abstract class for Viewmodel, so the update interface (and it's abstract method)can accept all viewmodel, but not only bill_update also, sorted usecases files under the package called usecases

xgao28 commented 1 year ago

Also, this pull request consists of commits from others, so you may want to open another pull request.

Yuhan-Ut commented 1 year ago

Also, this pull request consists of commits from others, so you may want to open another pull request.

Do you know how to avoid this? I did not noticed there are scott's commit here. How to start a pr that only my commit?

xgao28 commented 1 year ago

Also, this pull request consists of commits from others, so you may want to open another pull request.

Do you know how to avoid this? I did not noticed there are scott's commit here. How to start a pr that only my commit?

Creating a new branch that's up-to-date, and coding in the new branch may work?

Moreover, there are two pull requests from one branch that states separate goals. It would be better to create a new branch for every single goal, and in this way, we can separate the [+] adding implementation from [*] modifying.

Lei-Tin commented 1 year ago

I will not review this Pull Request at the moment, as it is not really urgent to be implemented. Furthermore, with Scott's ViewModel & Presenter Demo, I believe it is enough to test out these use cases.

Also, I believe by implementing the use cases first and completely, we can then decide on display and rendering issues later on.

But, nice start!

xgao28 commented 1 year ago

I reviewed the general idea of this pull request. Please refer my thoughts in this discussion. #37