Whitfield

[KevinShook]

Fixed some bugs and made some style improvements

Description

raster_qa.R - line 87 - changed graphics::image to raster::image

• removed unexecuted lines
• changed so that parameter is a data frame, not a file name, in the example and the parameter description

get_wscstation.R

• no longer passes HYDAT_list as a parameter
• changed internal reference to HYDAT_list , now finds HYDAT data correctly

read_wsc.R

• changed to explicitly read strings as characters. This may not be what you intended, so please ignore if this is the case.
• might be a good idea to include a line in the example writing the sample data to a .csv file, then reading it in with this function
• might be a good idea to rename this function as there are so many WSC formats, from different sources. Perhaps it could be called read_ECdataexplorer_WSC ?

Related Issue

Example

No test included - just small changes. Should now include unit tests as described in the new main branch.

[boshek]

For what it is worth, and I am admittedly biased, functions like read_wsc() and get_wscstation() are taken care by the tidyhydat package which provides direct access to HYDAT. tidyhydat soon be up on CRAN meaning that this package can import functions from tidyhydat. At the very least it creates a reproducible workflow that eliminates the need for the intermediate step of having .csv files stored locally.

[rchlumsk]

Provided some comments and feedback for @PaulWhitfield to take a look at. General overview:

• recommend changing the naming convention to the Google style (booth.plot instead of booth_plot, as per previous survey results)
• some tidying up of documentation and examples
• some other function specific issues to address

Vignette attached as .zip file included.

Whitfield_test_html.pdf Whitfield_test.zip

[rchlumsk]

Functions are pulled into master branch previously, closing this pull request and further updates will happen in the master branch.