search

CSHS-CWRA / CSHShydRology

Main package
GNU Affero General Public License v3.0
35 stars 39 forks source link

ECm.find, ECm.capture, ECm.capture.all and PMP #5

Closed vmunozs-zz closed 3 years ago

vmunozs-zz commented 6 years ago

Hi , I am including my function for the package. Any question just let me know

Description

For now, I am including the functions as a revision 1.0 to the package

Related Issue

Example

vmunozs-zz commented 6 years ago

About the general comment to remove the functions: ECm.find and ECm.capture and use weathercan, seems the logical step. I created these functions years ago, when I need that requirement and nothing was there (that I was aware). In any case, I already tried weathercan, and it seems a well-rounded package. I agreed to remove these functions and just use weathercan instead.

boshek commented 6 years ago

@vmunozs at this point this is in your hands. If you are able to make those requested changes great.