search

CSHS-CWRA / CSHShydRology

Main package
GNU Affero General Public License v3.0
35 stars 39 forks source link

Paul documentation edits #52

Closed PaulWhitfield closed 2 years ago

PaulWhitfield commented 2 years ago

Description

correct missing leading ch_

Related Issue

Example

KevinShook commented 2 years ago

Found a few bugs that need to be fixed before we can merge: ch_get_peaks: no visible global function definition for ‘head’

This is line 131 in ch_get_peaks.R head(POT_events) Is this debugging code?

ch_tidyhydat_ECDE_meta: no visible global function definition for ‘hy_sed_daily_loads’

hy_sed_daily_loads needs to be defined at the top of the function, i.e. hy_sed_daily_loads <- NULL

I also get this error:

  > ### Name: ch_get_peaks
  > ### Title: Extracts peak flows over a threshold
  > ### Aliases: ch_get_peaks
  > 
  > ### ** Examples
  > 
  > threshold <- 0.9*max(W05AA008$Flow)  # arbitrary threshold
  > my_peaks <- ch_get_peaks(W05AA008, threshold)
  Error in data.frame(st_date, max_date, max, volume, duration) : 
    arguments imply differing number of rows: 3, 2
  Calls: ch_get_peaks -> data.frame
  Execution halted