search

CTSRD-CHERI / cheribsd-ports

FreeBSD ports tree adapted for CheriBSD.
https://CheriBSD.org
Other
5 stars 10 forks source link

c18n: Enable -morello-bounded-memargs for purecap userland #141

Closed dpgao closed 6 months ago

dpgao commented 8 months ago

The cc script will use this flag by default starting with the next CheriBSD release.

kwitaszczyk commented 8 months ago

This is blocked by https://github.com/CTSRD-CHERI/cheribsd/pull/1981.

brooksdavis commented 6 months ago

This needs to bump PORTREVISION

dpgao commented 6 months ago

This needs to bump PORTREVISION

Do you mean PORTVERSION instead?

brooksdavis commented 6 months ago

This needs to bump PORTREVISION

Do you mean PORTVERSION instead?

Indeed. Usually this sort of thing is PORTREVISION based, but not in this case.

@kwitaszczyk I wonder if we should change this PORTVERSION to be a date (e.g. 20240315)?

kwitaszczyk commented 6 months ago

@kwitaszczyk I wonder if we should change this PORTVERSION to be a date (e.g. 20240315)?

I guess the date-based format might be easier to maintain as it'd be quite noticeable if llvm-bases used an old date despite of known later changes. Also, it might be helpful when correlating versions of llvm-base and llvm-morello as llvm-morello already includes a date in its version format.

These are not strong arguments but for sure I cannot see any disadvantages of the date-based format. I think we can switch to it.