search

CWSL / cwsl-mas

VisTrails plugin for Climate Model Analysis
Apache License 2.0
6 stars 32 forks source link

Constraint Input Port overrides Constraint Builder #4

Closed taerwin closed 10 years ago

taerwin commented 10 years ago

A constraint input port set manually on a dataset overrides a Contraint Builder Module. If a user accidently creates an empty contraint option it will try to fetch the entire dataset!

captainceramic commented 10 years ago

I think this should be a pretty easy fix - I can't think of any case when a user would want to remove all limitations on a particular constraint by replacing it with an empty string. The code that does the overwriting of constraints happens in the ProcessUnit, I think I can just check for empty string there.

captainceramic commented 10 years ago

This should do it - anything that python sees as False should not be able to overwrite the value of a constraint in a ProcessUnit.