search

CZ-NIC / django-fido

Django application for FIDO protocol U2F
GNU General Public License v3.0
28 stars 11 forks source link

Add support for fido2 1.1.0 #183

Closed MichalPham closed 1 year ago

MichalPham commented 1 year ago

Modified get_user_id to return bytes according to PublicKeyCredentialUserEntity specification.

There are also changes in related JSON serialization but it appears that custom encoder for handling bytes is still necessary.

MichalPham commented 1 year ago

I would like to see tests ran in both versions of fido2.

Test should now run with both fido == 1.0.* and fido == 1.1.*

tpazderka commented 1 year ago

Typing needs fixing.

But I will do it in a separate issue...

tpazderka commented 1 year ago

Typing needs fixing.

But I will do it in a separate issue...

And looking at that it is actually broken by the new fido lib. I think the best approach is to drop 1.0.0 and type according to 1.1.0.