Not Appstore safe? - Githubissues

CaliCastle / PopMenu

A fully customizable popup style menu for iOS 😎

https://popmenu.cali.so

MIT License

1.62k stars 185 forks source link

Not Appstore safe? #22

Open jeanmartin opened 5 years ago

jeanmartin commented 5 years ago

✔️ Issue Checklist

[x] I have updated PopMenu to the latest version.
[x] I have read the Contribution Guidelines.
[x] I have read the Documentation.
[x] I have searched for GitHub issues.

✍🏻 Issue Description

This line https://github.com/CaliCastle/PopMenu/blob/48c92438e2f15d69dc45d804b423637e30908b69/PopMenu/View%20Controller%20%26%20Views/PopMenuViewController.swift#L88 seems to be using a private API increasing the chance of getting rejected for the app store (according to https://forums.developer.apple.com/thread/87823 which also states this might fail on iOS 11).

CaliCastle commented 5 years ago

I didn't know that, I used it in my other project and passed TestFlight, but that's a good point and thanks for posting that forum link, I'll fix it in a minor update, thanks!