search

CambridgeSemiticsLab / nena

The North Eastern Neo-Aramaic Database Site
https://nena.ames.cam.ac.uk
5 stars 0 forks source link

Metadata not displayed for audio recordings #65

Closed GeoffreyKhan closed 3 years ago

GeoffreyKhan commented 3 years ago

When I enter metadata about a text the front end displays only the title 'metadata' but does not display the content of the metadata, e.g. https://nena.ames.cam.ac.uk/audio/185/

jamespstrachan commented 3 years ago

@GeoffreyKhan I have popped the metadata in to a new section between the audio waveform and the transcription. You can see it on staging, eg here: https://nena-staging.ames.cam.ac.uk/audio/93/

GeoffreyKhan commented 3 years ago

The metadata display looks OK to me. Though, I've two comments:

  1. If we add a long string in one of these boxes, would the text expand continuously to the right, throwing out the column arrangement, or would it have a column boundary and wrap around that (preferred)?
  2. I don't think we need the Place slot in the metadata. Nor do we need the Recording date, since we do not have this information for all our recordings.
GeoffreyKhan commented 3 years ago

I suggest removing the 'Place' column of the metadata, since we do not have a record of where many of the recordings were made.

jamespstrachan commented 3 years ago

re: (1) Try it! Remember the staging instance is completely separate from production so if you are curious about how different data inputs might affect the site then feel free to try them out and see. I have put in some very-long metadata here and it does indeed wrap within the table, following standard web-table wrapping rules (eg. makes columns with more text in them wider)

re: (2) As this was from your original spec are you happy with Audio.place to be dropped @codykingham? The alternative is to keep it as an optional field (and we can hide that column in the metadata table on an instance which has no place)

GeoffreyKhan commented 3 years ago

This seems OK, now, but please remove 'Place'.

jamespstrachan commented 3 years ago

Again, Audio.place was added with the agreement of @codykingham so as courtesy I'll check it doesn't break his TextFabric ingestion pipeline by removing it!

codykingham commented 3 years ago

Yes, it is ok to make this feature optional, as it is not a required feature. Going forward, it would be better as @jamespstrachan suggests to have it optional rather than delete it all together. That is because some of our text-corpus items have places associated with them, and it wouldn't make much sense to be deleting data. Unless we can say that these "places" are better associated with dialects—though that is a separate discussion.

GeoffreyKhan commented 3 years ago

OK, fine. I see Cody's point. Best to leave Place optional.

jamespstrachan commented 3 years ago

@GeoffreyKhan please confirm current work on staging instance is non-breaking (even if it's not in its final form) by applying ready for production label. Once all on staging issues are marked ready for production I will roll everything out at once and resume development on the next batch of issues.