CandyShop / gerrit

Automatically exported from code.google.com/p/gerrit
Apache License 2.0
1 stars 0 forks source link

Issue tracking systems (all) don't work when plugin.<name>.branch is specified #3386

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hi.
All Issue tracking systems don't work when plugin.<its-name>.branch is 
specified. Problem is in 
its-base/src/main/java/com/googlesource/gerrit/plugins/hooks/its/ItsConfig.java

When affected branch for its is specified e.g. 

plugin.its-bugzilla.branch = refs/heads/*

then it is tested in "public boolean isEnabled(ChangeEvent event)" function and 
argument passed to next isEnabled is "e.change.branch". But this is a short 
name of the branch 

in 
gerrit/gerrit-server/src/main/java/com/google/gerrit/server/events/EventFactory.
java

a.branch = change.getDest().getShortName();

---
e.change.branch contains for "refs/heads/master" only "master" and for 
"refs/meta/config" it contains full branch name "refs/meta/config"

I wonder if it ever worked. Support was done by 
https://gerrit-review.googlesource.com/#/c/53659/

Issue #3380 should be merged to this one.

Original issue reported on code.google.com by eng...@gmail.com on 21 May 2015 at 5:39

GoogleCodeExporter commented 9 years ago
I see the resolution already in master branch 
https://gerrit-review.googlesource.com/#/c/67850/.

Please close.

Original comment by eng...@gmail.com on 21 May 2015 at 7:56

GoogleCodeExporter commented 9 years ago

Original comment by edwin.ke...@gmail.com on 22 May 2015 at 1:44