CandyShop / gerrit

Automatically exported from code.google.com/p/gerrit
Apache License 2.0
1 stars 0 forks source link

Search highlighting in side-by-side diff #3438

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version:

What steps will reproduce the problem?
1. open a diff
2. search for a word that appears in any modified line
3. matches in /unmodified/ lines are highlighted (yellow), but matches in 
modified lines (that are already highlighted green/red/...) are not 
highlighted, and thus not immediately visible. The (very small) cursor at the 
match is not enough indication.

What is the expected output? What do you see instead?
A highlight where the search matches.

Please provide any additional information below.

Original issue reported on code.google.com by duft.mar...@gmail.com on 17 Jun 2015 at 10:57

GoogleCodeExporter commented 9 years ago
Ups sorry: version is 2.11

Original comment by duft.mar...@gmail.com on 17 Jun 2015 at 10:57

GoogleCodeExporter commented 9 years ago
Can't reproduce on gerrit-review, using chrome: [1].

* [1] http://imgur.com/zsAREjE

Original comment by David.Os...@gmail.com on 21 Jun 2015 at 6:14

GoogleCodeExporter commented 9 years ago
we're seeing the issue on Gerrit 2.11, I can reproduce on my machine (I'm not 
the original reporter) using both chrome and firefox:

chrome: http://imgur.com/wHX5dfl
ff: http://imgur.com/wY2jQzQ

Gerrit 2.11, Linux: Fedora 20, Chrome: 43.0.2357.124 (64-bit), FF: 38.0.1

Original comment by duft.mar...@gmail.com on 22 Jun 2015 at 5:14