search

Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite
https://cantera.org
Other
580 stars 341 forks source link

Broken flame examples in experimental MATLAB toolbox #1722

Open ischoegl opened 6 days ago

ischoegl commented 6 days ago

Problem description

flame1.m, flame2.m and diff_flame.m examples no longer work: the first fails to converge, and temperatures of the other two are equal to inlet temperatures.

Steps to reproduce

  1. Install Cantera from scratch
  2. Follow instructions in interfaces/matlab_experimental/readme.md
  3. Run one of the flame examples

Behavior

No combustion is observed

System information

Other context

Issue was discovered when testing changes in #1619, but same behavior was observed on current main.

speth commented 6 days ago

Using the experimental Matlab toolbox from main with libcantera from 3.0.0 (conda-forge package), I observe the same problems with all three examples.

Using the experimental Matlab toolbox from v3.0.0 with libcantera from 3.0.0 (conda-forge package), flame1.m and flame2.m exhibit the same problems. However, diff_flame.m successfully solves a non-extinct flame.

ischoegl commented 6 days ago

Thanks for confirming, @speth. I’m surprised that this didn’t work as far back as when we released 3.0. Tagging @ssun30 and @rwest …

rwest commented 6 days ago

We'll take a look this week. I think some MATLAB toolbox work is in our docket anyway. Thanks for tagging us.

speth commented 6 days ago

git bisect tells me that the commit that broke diff_flame.m is this one: 3a9bc6a66d10e40ce9194542701c54b8b60e612b.

ischoegl commented 5 days ago

@rwest and @ssun30 ... please make sure to rebase after #1619 is merged, as that PR introduces some updates to nomenclature, which affect clib (it actually adopts MATLAB nomenclature for Flow1D within C++, as it makes more sense than the old StFlow)

PS: #1619 is now merged.