Canvasbird / canvasboard

An interactive board with plugins focusing on replacing the need of multiple platforms for teaching, presenting, managing or explaining your ideas.
MIT License
199 stars 120 forks source link

Embed link and YT link validation #478

Closed Aniket-508 closed 2 years ago

Aniket-508 commented 2 years ago

Issue that this pull request solves

Closes: #471

Brief description of what is fixed or changed

Made a custom url and yt url regex and then used ternary operator which basically adds the board component if the value entered matched the regex else gives alert to enter a valid url or valid yt url

Types of changes

Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply

Screenshots

Screenshot (158) Screenshot (159)

guardrails[bot] commented 2 years ago

:warning: We detected 1 security issue in this pull request:

Insecure Use of Regular Expressions (1)
Docs | Details ----- | -------- [:bulb:](https://docs.guardrails.io/docs/en/vulnerabilities/typescript/insecure_use_of_regular_expressions.html?utm_source=ghpr) | Title: **Regex DOS (ReDOS)**, Severity: Medium
https://github.com/Canvasbird/canvasboard/blob/69f725286ccc8bafa2f2d000c9764702f6917a21/src/app/components/new-board/new-board.component.ts#L1143 More info on how to fix Insecure Use of Regular Expressions in [TypeScript](https://docs.guardrails.io/docs/en/vulnerabilities/typescript/insecure_use_of_regular_expressions.html?utm_source=ghpr).

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Aniket-508 commented 2 years ago

@goliakshay357 Please have a look at this.

goliakshay357 commented 2 years ago

LGTM!