search

CaoTrongThang / better-campfires-1.20.1

campfire that gives you buff when staying close
2 stars 2 forks source link

Tag support for adding fuels #7

Closed neonjuno closed 1 month ago

neonjuno commented 1 month ago

It would be good if instead of writing each item one-by-one we could add an item tag instead, e.g.

{
      "fuelTag": "minecraft:logs",
      "addBurnTime": 800
}
CaoTrongThang commented 1 month ago

Take a look mate.

neonjuno commented 1 month ago

That was really quick! Thank you so much.

neonjuno commented 1 month ago

Also, since I don't want to open another issue for this, I see that in the code there is some NBT stuff, but is it implemented? When I check a campfire's NBT in game there's no mention of a BurnTime.

CaoTrongThang commented 1 month ago

Also, since I don't want to open another issue for this, I see that in the code there is some NBT stuff, but is it implemented? When I check a campfire's NBT in game there's no mention of a BurnTime.

I don't really understand what you mean, I mean it has the NBT, if you use the mod with Carry On so when you pick the campfires up, it won't reset the burnTime

neonjuno commented 1 month ago

Sorry, I didn't really understand NBT when I made that comment, what I meant was syncing the NBT data to the client side so it could be changed by the player, like the campfire's "lit" state for example

CaoTrongThang commented 1 month ago

Well that's a not good behavior, if the players know to "hack", they can change the network package and tell campfires to have infinite burnTime