search

Caoimhinmg / PmagPy

Python-based tools for Paleomagnetic research
scripps.ucsd.edu
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Order of operation for going to Python 3 #8

Open moonshoes87 opened 7 years ago

moonshoes87 commented 7 years ago

Here's an idea for what needs to happen to get us switched over to Python 3. I'm still discussing some details with Lisa, but I think we should be able to move forward. Once that happens, I'll email other developers to get them into the conversation.

I'd like to go ahead and work mostly on the first set of tasks, i.e. getting the current PmagPy Python 2 branch really robust and re-released. @Caoimhinmg, if you find more bugs in the Python 3 branch that you want me to look at, I can jump back and forth.

Let me know if there are steps missing, or that seem out of order here...

Get Python 2 stuff set up and stable

  1. Ensure that current PmagPy/PmagPy is nice and stable
  2. Create PmagPy Python 2 branch off of master
  3. Make new pip release
  4. Make new standalone releases

Get Python 3 set up

  1. Decide how best to have a Python 2 vs. Python 3 PmagPy pip package available
  2. Finish quality control checking of Python 3 PmagPy branch
  3. Merge Python 3 PmagPy branch into master
  4. Provide check sheet for Python 2 vs. Python 3
  5. Update all developers on how to do future development (Python 3)
  6. Update the Cookbook with Python 2 vs. Python 3 install instructions

Business as usual

  1. Continue development in Python 3
  2. Fix bugs if needed on Python 2 PmagPy branch, maintain availability of Python 2 PmagPy release
Caoimhinmg commented 7 years ago

@moonshoes87. This is a good list, though I think it will be best moved to the pull request forum once all of the first phase (1-4) is done. We can do the shout out to the other developers (just tag everyone) and the quality control checking from there as well. Because once the pull request is made it's almost like a branch of the main repo so it can be managed from the main repo and I don't have to add everyone as a contributor over here. Finally on the note of 8 I'm working on that a bit right now setting up a framework for a notebook explaining the details, though I can switch to making stand alone releases (4) once the main repo is declared stable and the python2 branch is made.

moonshoes87 commented 7 years ago

Ok great, I'm running through tests in the main repo now. Things have been pretty stable, so that part is relatively simple.

Setuptools is giving me some crazy new errors, though, so I'm not sure exactly how long the pip release is going to take.

moonshoes87 commented 7 years ago

Finally got that resolved -- setuptools changed something, I guess, so that any absolute paths in setup.py broke everything. Also, having stray files in data_files ( there was one called atrm_results.txt, I think), will break everything.

Anyway, I just made a new pmagpy/pmagpy-cli release. Everything is working, as far as I can tell.

So, items 1, 2, and 3 are done. The branch is creatively named Python2. I will make and test an OS X standalone release tomorrow. @Caoimhinmg, I now have my Windows virtual machine set up, so I should make sure I know how to do the Windows release before you drop off the map, but maybe after we deal with some more of the Python 3 stuff. If you can do the Windows/Linux release, that would be great.

moonshoes87 commented 7 years ago

OS X release is up.