Closed clearlysid closed 6 months ago
options.targets is now options.target and accepts an Option
instead of Vec
We kept it as Vec
@Pranav2612000 I had mentioned this change here, thought your green check mark meant you approve 😅 https://discord.com/channels/1044321624545046569/1189167062019477567/1244658459396280435
https://discord.com/channels/1044321624545046569/1189167062019477567/1244658459396280435
Yup! My bad. Looking at the code now made me remember this scenario. Also I'm not sure how windows does it, but for Mac we won't need to spawn a new capturer for each target. ScreenCaptureKit APIs accept multiple targets.
Also I'm not sure how windows does it, but for Mac we won't need to spawn a new capturer for each target. ScreenCaptureKit APIs accept multiple targets.
I checked this as well — It can't accept "multiple" targets in a conventional sense. You can only ever capture a single display at a time, the multiple targets are only for:
Case 1: not relevant for us at the moment since we only want individual window capture
Case 2: we have accounted for using excluded_targets
option.
Reference here: https://developer.apple.com/documentation/screencapturekit/sccontentfilter See each topic under "Creating a filter"
Changes:
source_rect
is renamed tocrop_area
(easier to understand)options.targets
is nowoptions.target
and accepts anOption<Target>
instead ofVec<Target>
.main.rs
is updated to reflect all these changes (will update Readme last after all other PRs are merged)