Implementation of automatic detection of RNGs

[sonofmun]

It should detect and donwload if it is remote and detect and use if it is local. Also wrote unit tests for this. I would also suggest removing the "remote" and "local" flags from the command line (https://github.com/Capitains/HookTest/blob/custom_dtd/HookTest/cmd.py#L25) and the "custom_rng" scheme and test (e.g., https://github.com/Capitains/HookTest/blob/custom_dtd/HookTest/capitains_units/cts.py#L430-L460),

[sonofmun]

Issue #58 (finally)!

[coveralls]

Coverage increased (+0.4%) to 95.789% when pulling 529cdef03c67e0b65d0ed45eb8188523ee5881a9 on custom_dtd into c4b5fd72382eb885912e6be3951b19e1c6c00969 on master.

[sonofmun]

The reduction in coverage is due to the objects and functions around the custom_dtd test. If this is deleted, coverage should be more acceptable.

[PonteIneptique]

Should we have a call tomorrow or the day after to review this together ?

[sonofmun]

Sure.

[sonofmun]

Changes have been made. Take a look.

[sonofmun]

Need to add a unit test for when the --scheme argument is a file path.

[PonteIneptique]

Should I wait for the unit-test for merging ?

[sonofmun]

Hi Sorry. Yes, wait for the next commit. I actually didn't even implement the local file option on --scheme. So I am trying to do that now before I run out of energy for the day.

[PonteIneptique]

Good luck !

[PonteIneptique]

Should it be in this PR that we update the README ?

[sonofmun]

Implemented and tested. Don't merge yet. If you approve, just keep your review as approved and I will look at everything more closely tomorrow. Right now I am too tired to be able to judge very well what I did. I will then squash and merge if everything looks good in the morning.

[PonteIneptique]

Looks good to me. Will remain README, bump and CHANGES.md to do :)

[sonofmun]

I assume this is a minor revision and so we should bump to 1.2.

[PonteIneptique]

Minor but yes, 1.2.0 : https://semver.org/ :)

[sonofmun]

I said "minor" revision. Just look at my comment!

[PonteIneptique]

Sorry buddy, github updated their edit policy :

[PonteIneptique]

:D

[sonofmun]

Damn! Transparency sucks!

[sonofmun]

Now on to:

• [x] README
• [x] CHANGES.md
• [x] bump version

[PonteIneptique]

Yay !

[sonofmun]

If you are still OK with the changes, then I will squash and merge once all checks pass.

[PonteIneptique]

Squash and merge away !

[PonteIneptique]

Congrats !