Clean up test.run code.

Capitains / HookTest

Testing script for Hook

Mozilla Public License 2.0

3 stars 3 forks source link

Clean up test.run code. #146

Closed rillian closed 5 years ago

rillian commented 5 years ago

This is some cleanup of the code around the parallel iterators in Test.run I did while investigating #145.

The file lists returned by the finder are already iterable, so there's no need to create a new list from them. If there were just wrapping them in list() is another possiblity.

Also update the comments so they match the code better.

coveralls commented 5 years ago

Coverage increased (+0.09%) to 95.71% when pulling 93a323874b99679faf1b8057a1192828eb5a11fd on rillian:run-cleanup into 01240017a9bdf5b36227f19337e9649af44af3e9 on Capitains:master.

PonteIneptique commented 5 years ago

Dear @rillian , my complete apologies. I am in a deep tunnel regarding this. Maybe @sonofmun can chime in ?

sonofmun commented 5 years ago

I should have time to take a look at it later this week. Ping me again if you haven't heard anything by Thursday (June 20).

rillian commented 5 years ago

Ok. Thanks for the update!

PonteIneptique commented 5 years ago

Love the change in comments, definitely a good pr. Thanks !

rillian commented 5 years ago

\o/