Adapt background sound volume based on video volume

CaptainFact / captain-fact

📚 Documentation, wiki and community discussions

https://captainfact.io

67 stars 7 forks source link

Adapt background sound volume based on video volume #93

Open Betree opened 5 years ago

Betree commented 5 years ago

We should retrieve the volume from ReactPlayer and adapt background notifications volume accordingly. As of today the volume can be too strong or too low.

[ ] Store the volume from ReactPlayer in redux state
[ ] Retrieve the value in app/components/App/BackgroundNotifier.jsx
[ ] Set audiofile.volume = ___ for all notifications types (refute/confirm/neutral)

Betree commented 5 years ago

:money_with_wings: A 30€ bounty was attached to this issue. Anyone submitting a Pull Request will be rewarded with 30€ when the Pull Request is reviewed, accepted and merged. More info.

Miragide commented 4 years ago

@Betree maybe should you give more explanation of this issue?

Betree commented 4 years ago

If your computer volume is 100% and you put the video's volume at 10%, the notifications will keep popping loud. The idea is to synchronize the volume of notifications with what you put in the player.