CareEvolution / MyDataHelpsUI

MyDataHelps UI React Component Library
MIT License
1 stars 2 forks source link

Add support for Brazilian Portuguese (pt-BR) #333

Open basyl-durnan opened 1 month ago

basyl-durnan commented 1 month ago

About

Adding support for Brazilian Portugues (pt-BR) for the CLUES project.

MDH UI and View Utils - Locale Definition

This creates the translations for the MDH UI components and view builder.

Code Changes

In the MyDataHelpsUI repo:

  1. Copy the English language file to make one for the new language.
  2. Send out for translations.
  3. Once merged, deploy a new NPM package with the updated strings.
  4. Once the new MDH UI version is published, update MDH View Builder to reference it.
  5. Ditto for the MDH View Library.

Note: The view builder main branch is deployed to QA automatically. Once tested, another PR is necessary to merge to the prod branch and deploy to prod. This can be done outside a release cycle.

Testing

From the Localization Test Plan:

basyl-durnan commented 1 month ago

We already have pt supported and I believe the other two repos already reference it since it is available in prod.

@lynnfaraday do you know how I could verify?

basyl-durnan commented 1 week ago

Awaiting https://github.com/CareEvolution/MyDataHelpsUI/pull/361

lynnfaraday commented 1 week ago

@basyl-durnan I don't think we need to wait on that one. Those localization gaps exist in all existing languages too and it wasn't a showstopper.

lynnfaraday commented 1 week ago

I do think we need PT-PT to be added, though, to match the other apps.

basyl-durnan commented 1 week ago

So is the only thing left to do is update View Builder and View Library with the latest MDH UI version?

lynnfaraday commented 4 days ago

@basyl-durnan No, I think we need to actually add PT-PT translations. THEN we can make a release and update the view builder/library.

basyl-durnan commented 4 days ago

I thought we were just going to go with "pt" for now and it really be "pt-BR"? Apologies if I missed some conversation.

Would that mean we need to do everything we just did for pt-BR for pt-PT?