search

Carglglz / upydevice

Python library to interface with MicroPython devices through Wifi (Websockets/WebREPL) , BLE or Serial connection (USB)
MIT License
18 stars 6 forks source link

Missing `netifaces` and `python-nmap` requirements in setup.py #10

Closed BradenM closed 2 years ago

BradenM commented 2 years ago

Hi @Carglglz,

I've recently started implementing a new backend for pydevice communication that utilizes upydevice in micropy-cli (see https://github.com/BradenM/micropy-cli/pull/294 if you are curious :smile: ) and noticed that the setup.py does not include the netifaces and python-nmap requirements used in websocketdevice.py. W/o these deps, upydevice fails to import.

On a related note, I felt I should mention that I've been very happy using this library so far! I sincerely appreciate the thought and work you've put into this. Thank you!

Carglglz commented 2 years ago

Hi @BradenM Thanks for reporting this, I will fix it asap.

On a related note, I felt I should mention that I've been very happy using this library so far! I sincerely appreciate the thought and work you've put into this. Thank you!

I'm glad you find it useful 😁 and related to https://github.com/BradenM/micropy-cli/pull/294, I've recently refactored upydev, so you may be want to check upydev dsync for syncing project folders or upydev.shell to implement a custom solution adapted to micropy-cli 👍🏼

BradenM commented 2 years ago

@Carglglz I will definitely take a look! Thanks!