Closed EliasJRH closed 3 months ago
Nit: Call it
websocket_commands
instead oftelemetry_websocket_commands
just because its already in the telemetry directory. Then imports look liketelemetry.websocket_commands
I like this, while we're at it I don't think it'd be a bad idea to do the same for other similarly named files
This PR contains some suggested changes that I came up with while documenting the ground-station code. The current notable changes are:
commands.py
in the websocket module towebsocket_commands.py
in the telemetry module. This file only contains logic for parsing incoming commands for the Telemetry process so it seems fitting that the file should exist in the telemetry moduletelemetry.py
to match their name inmain.py
. This is mainly a nit but it also just clears up some initial confusingjson_packets.py
intostatus.py
- which contains the newly namedTelemetryStatus
class and its associated classes and enums to hold status of telemetry backend - anddata.py
which contains theTelemetryData
and the newly namedTelemetryDataPacket
classes.utils.py
and rename it toparsing_utils.py
On the subject of the last notable change, I was thinking of moving
parsing_utils.py
into thev1
directory as it's technically built on top of the v1 spec.