CarletonURocketry / ground-station

The ground station software used to interface with the ground station LoRa board and distribute signals from the rocket across websocket connections.
https://carletonurocketry.github.io/ground-station/
MIT License
7 stars 6 forks source link

Document and refactor ground-station code #107

Closed EliasJRH closed 3 months ago

EliasJRH commented 4 months ago

This PR contains some suggested changes that I came up with while documenting the ground-station code. The current notable changes are:

On the subject of the last notable change, I was thinking of moving parsing_utils.py into the v1 directory as it's technically built on top of the v1 spec.

EliasJRH commented 4 months ago

Nit: Call it websocket_commands instead of telemetry_websocket_commands just because its already in the telemetry directory. Then imports look like telemetry.websocket_commands

I like this, while we're at it I don't think it'd be a bad idea to do the same for other similarly named files