search

CarlosNZ / json-edit-react

React component for editing/viewing JSON/object data
https://carlosnz.github.io/json-edit-react/
MIT License
183 stars 18 forks source link

Minor issue with <label> #47

Closed maxpaleo closed 6 months ago

maxpaleo commented 6 months ago

Minor issue, but it would be useful to fix it to prevent the browser from throwing errors. The keys are rendered using a <label/> element, which has a for property, but the value doesn't specify the matching ID; causing warnings.

Screenshots

Screenshot 2024-04-28 at 10 37 12 PM
CarlosNZ commented 6 months ago

Yeah, sure, can fix that. Thanks for pointing it out. Look for an update in a day or two.

CarlosNZ commented 6 months ago

Fix coming in next release (in the next day or so).

I've just turned the <label> elements into <span>s, as there is no static connection between the label and its input, so the for attribute is not helping at all.

CarlosNZ commented 6 months ago

Should be fixed in 1.9.0 -- available now :)

maxpaleo commented 6 months ago

Perfect, thanks!