CarsonHoffman / office-hours-queue

11 stars 7 forks source link

[Feature Request] Sync OH Schedule with Given Google Calendar #25

Closed developStorm closed 2 years ago

developStorm commented 2 years ago

Resolves issues like #19. This should be very handy when OH schedule needs ad-hoc changes and as well as for class that don't necessarily has same OH schedule from week to week.

There may still be some issues with the actual implementation, such as most courses mix listing virtual office hours with in-person office or even lectures. This can be solved by synchronizing only events with a specific pattern in name.

CarsonHoffman commented 2 years ago

I think that this is out of scope for the queue itself given the various complexities across different courses as you alluded to. You're free to pull that information on your end and hit the schedule API endpoint manually.

developStorm commented 2 years ago

I think it still makes sense for a scheduling-based queue to have this feature. Use an external script is huh okay but maintain the session token with Google OAuth2 would be a pain consider the script should be designed as unattended.

I can try to offer an implementation to this feature if you think it can possibly be merged, or, would it be possible to have an API key (long-term session) authentication mechanism?

y2kmurali commented 2 years ago

Might it also be possible to have a "manual OH" mode instead of the scheduling to allow courses to have one source of truth (e.g. a google calendar or something) and then instructors can just manually open/close the queue when holding OH? That was our workflow on the old OH queue and it seemed to work fine.

I have no issues with the scheduling system as a whole but I totally can see how inconsistencies can lead to issues if the OH queue doesn't align with other sources.