search

CartoDB / cartodb-postgresql

PostgreSQL extension for CartoDB
BSD 3-Clause "New" or "Revised" License
111 stars 53 forks source link

Clearly communicate compatible postgresql version #328

Closed andy-esch closed 6 years ago

andy-esch commented 6 years ago

With the introduction of the new CDB_QuantileBins, this extension is only compatible with postgresql versions 9.4+. There may be other features like being marked parallel which break backwards compatibility.

It would save users some headaches (for example https://github.com/CartoDB/cartodb-postgresql/commit/39998a9c88e788d1982f468427531f7314e039ed#r28723290) if there was a version check that aborted the install and communicated the supported versions if the pg version is not supported.

andy-esch commented 6 years ago

cc @Algunenano

Algunenano commented 6 years ago

Being marked PARALLEL shouldn't affect since it's dropped for non compatible releases, so we could simply update the [dependencies])(https://github.com/CartoDB/cartodb-postgresql/blob/master/README.md#dependencies) in the README. Although that would be enough I think we should be running the CI with whatever PG releases we want to support.

andy-esch commented 6 years ago

100% on the CI for PG releases. I'll do a quick PR to update the README