search

CartoDB / cartodb-postgresql

PostgreSQL extension for CartoDB
BSD 3-Clause "New" or "Revised" License
111 stars 52 forks source link

Fix for collation errors when importing catallog tables #394

Open rafatower opened 4 years ago

rafatower commented 4 years ago

This fixes #393 by avoiding collation options. The affected function is only used from diagnostics, and aside from pg_extension only meant to import other catallog tables for internal diagnostics (pg_catalog and pg_settings) so it shall be pretty safe.

Algunenano commented 4 years ago

Can you explain why this is needed here and not in the other places where IMPORT FOREIGN SCHEMA is called?

rafatower commented 4 years ago

Because of default collations, checks in FDW's, and catallog tables using NAME type.

Algunenano commented 4 years ago

I'm sorry but I don't understand it. What about a foreign table that uses NAME as one of the column, is that different? How?

rafatower commented 4 years ago

I suspect it is not different at all, just less common