Resolve intersection errors

CartoDB / observatory-extension

BSD 3-Clause "New" or "Revised" License

6 stars 4 forks source link

Resolve intersection errors #265

Closed talos closed 7 years ago

talos commented 7 years ago

Resolves intersection errors we were seeing (#248) and adds test to catch
Resolves divide-by-zero errors we were also seeing (#248)

talos commented 7 years ago

@andy-esch Would you mind taking a quick look at the code, let me know if you see any warts?

This should fix the issues you were seeing once deployed.

talos commented 7 years ago

@andy-esch Made suggested changes. RE using || instead of format, I found it more readable for long strings since format (AFAIK) doesn't have a keyword-substitution option, so debugging which argument goes where is a pain. Are you aware of a way around that?

Would appreciate a last-pass, then will start the process of merging.

andy-esch commented 7 years ago

LGTM!

On format, nope, only seen arguments referenced based on position in the list after the string.