Firefox TestPilot breaks image replacement.

[bacconnaise]

I have the latest firefox version and i do not see ads but i dont see cats either. I have included a screenshot of a site that has ads but i dont see the ads nor the cats. I have also thrown in a screenshot with the CatBlock paused on the page for comparison.

Do you have any other comments? If you can, can you please attach a screenshot of the bug?
=== Filter Lists === adblock_custom last updated: Wed, 20 Dec 2017 18:20:30 GMT easylist last updated: Wed, 20 Dec 2017 18:20:34 GMT malware last updated: Wed, 20 Dec 2017 18:20:31 GMT antisocial last updated: Wed, 20 Dec 2017 18:20:37 GMT

=== Custom Filters ===

=== Settings === catblock: true debug_logging: false youtube_channel_whitelist: false whitelist_hulu_ads: false show_context_menu_items: false show_advanced_options: true display_stats: true display_menu_stats: true malware-notification: undefined

=== Other Info === CatBlock version number: 1.4.9 Developer UserAgent: Mozilla/5.0 (Windows NT 10.0 Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

[itskdog]

Hi!

Due to how CatBlock works on top of AdBlock's codebase, we are currently unable to replace ads that can be blocked from being dowloaded in the first place, as the browser doesn't inform us of the location of the ad after it has blocked it. These ads are listed in red on the resource list page in the screenshot you sent us.

If it is an ad that cannot be blocked, AdBlock is able to hide it, by making it invisible. CatBlock is currently able to replace those ads only. If you have advanced options enabled (which according to your debug information, is enabled) these hidden ads will show in blue on the resource list page.

Is this problem on this website only? I often test using the Reddit homepage. There is usually a cat or two showing in the sidebar on the right-hand side of the page.

Hope this helps! Kieran

[bacconnaise]

Hi,

To be honest, I think it's something with the add-on in Firefox. I don't see in the options any selections available for the pictures in Firefox and I don't see any adds or any cats on Reddit either.

That same website that I sent the screenshots of, I tested it in chrome and see cats in all places where the ads are and I also see cat picture selections available in the options in Chrome.

Do you think it's something with the code in Firefox?

Do you want me to send you any debug logs from chrome to compare with?

Thanks!

Sent from BlueMailhttp://www.bluemail.me/r?b=11327 On Dec 21, 2017, at 6:33 AM, Kieran notifications@github.com<mailto:notifications@github.com> wrote:

Hi!

Due to how CatBlock works on top of AdBlock's codebase, we are currently unable to replace ads that can be blocked from being dowloaded in the first place, as the browser doesn't inform us of the location of the ad after it has blocked it. These ads are listed in red on the resource list page in the screenshot you sent us.

If it is an ad that cannot be blocked, AdBlock is able to hide it, by making it invisible. CatBlock is currently able to replace those ads only. If you have advanced options enabled (which according to your debug information, is enabled) these hidden ads will show in blue on the resource list page.

Is this problem on this website only? I often test using the Reddit homepage. There is usually a cat or two showing in the sidebar on the right-hand side of the page.

Hope this helps! Kieran

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FCatBlock%2Fcatblock%2Fissues%2F161%23issuecomment-353329091&data=02%7C01%7C%7C1d3eb698b1f04cce415808d54866a3d6%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636494528023416208&sdata=rFTBhO7WPuyI5%2BDMbekdDknPrJPHq9779Qb2R9XhJcw%3D&reserved=0, or mute the threadhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAhHKU77LFtBWfdPvzCvHpL5ehFZYUopAks5tCkH_gaJpZM4RIy95&data=02%7C01%7C%7C1d3eb698b1f04cce415808d54866a3d6%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636494528023416208&sdata=q8P55fIqPrDZcsbFq4YGERnAIjg4haEHhVdxklWOlik%3D&reserved=0.

[bacconnaise]

Hi, I have figured out the issue and I think that, with the new Firefox browser that was launched recently, it would be good to like put a notice somewhere to inform other who might have the same issue.

I have the Firefox Test Pilot add-on installed (https://testpilot.firefox.com/experiments). After disabling it, BAM! cats4ads!

I do now see the cats instead of the ads and this is the best add-on ever. Why would someone not want cats for ads seriously ?!

Just to give you an idea, I have attached the screenshots I get now in Firefox and with all the cats!

But yeah, I think it would be good to drop a note on this if others happen to have the Test Pilot add-on installed that they won't see cats unless they disable it.

[itskdog]

Hi again!

Thanks for the info!

I'm using Firefox, and have just installed TestPilot, and all seems OK to me. What experiments did you have enabled in TestPilot?

It's best that we can reproduce the behaviour on our end before we can even try fixing it.

Thanks, Kieran

[bacconnaise]

Hi Kieran,

Make sure to close and re-open Firefox if you just installed the Test Pilot. You should see a humpty-dumpty egg type of icon in the top-right for the Test Pilot add-on when the install is completed.

I only have the Notes and Snooze Tabs and Notes installed through the Test Pilot.

However, after disabling the Test Pilot addon, the Snooze Tabs and Notes are still available without interference for the ads replacement.

I just tested re-enabling the Test Pilot add-on, closed and reopened Firefox, and the issue is back and no ads are replaced with cats.

Hope that helps!

Thank you!