CatxFish / obs-v4l2sink

obs studio output plugin for Video4Linux2 device
GNU General Public License v2.0
931 stars 99 forks source link

Missing ObsPluginHelpers.cmake #1

Open ColinHarrington opened 5 years ago

ColinHarrington commented 5 years ago

I'm having an issue building the plugin, it seems like the repo is missing the [ObsPluginHelpers.cmake] https://github.com/CatxFish/obs-v4l2sink/blob/69ce76391a9865c8b01708ed4eb925ddc2bfabb3/external/FindLibObs.cmake#L98

Output:

$  cmake -DLIBOBS_INCLUDE_DIR="$LIBOBS_PATH" -DCMAKE_INSTALL_PREFIX=/usr ..
CMake Error at external/FindLibObs.cmake:98 (include):
  include could not find load file:

    /usr/share/obs/libobs/../cmake/external/ObsPluginHelpers.cmake
Call Stack (most recent call first):
  CMakeLists.txt:5 (include)

-- Configuring incomplete, errors occurred!
See also "/obs-vl4l2sink/build/CMakeFiles/CMakeOutput.log".

I'm guessing it's missing from when you copied from obs-virtual-cam

ColinHarrington commented 5 years ago

Looks like this relies on having the OBS project's ObsPluginHelpers.cmake available and not compatible with the binary installations.

CatxFish commented 5 years ago

I'll fix it later.

Lucretia commented 4 years ago

Can you fix this please?

Vulwsztyn commented 4 years ago

+1

dylanjw commented 4 years ago

The build process requires the obs-studio source code. You need to have a clone of the obs-studio project in the same directory as the clone of obs-v4l2sink before building.

git clone --recursive https://github.com/obsproject/obs-studio.git
git clone https://github.com/CatxFish/obs-v4l2sink.git
cd obs-v4l2sink
mkdir build && cd build
cmake -DLIBOBS_INCLUDE_DIR="../../obs-studio/libobs" -DCMAKE_INSTALL_PREFIX=/usr ..
make j4
sudo make install
Lucretia commented 4 years ago

The build process requires the obs-studio source code. You need to have a clone of the obs-studio project in the same directory as the clone of obs-v4l2sink before building.

git clone --recursive https://github.com/obsproject/obs-studio.git
git clone https://github.com/CatxFish/obs-v4l2sink.git
cd obs-v4l2sink
mkdir build && cd build
cmake -DLIBOBS_INCLUDE_DIR="../../obs-studio/libobs" -DCMAKE_INSTALL_PREFIX=/usr ..
make j4
sudo make install

And it's annoying because it cannot be packaged easily, especially on gentoo. Having this be self contained would be better.

rossmeier commented 4 years ago

I use this patch (https://github.com/CatxFish/obs-v4l2sink/compare/master...veecue:system-libs) for packaging this and add a bulild dependency to obs-studio-devel (on Fedora), obs-studio (on Arch, already contains the cmake and headers) or however it is called on your distro

ajlogo commented 4 years ago

The correct make line includes '-': make -j4 These and with the above clone of obsproject allows for the instructions at: https://github.com/CatxFish/obs-v4l2sink to be successful. This includes the instructions about v4l2loopback at: https://github.com/umlaeute/v4l2loopback#run

rossmeier commented 4 years ago

@ajlogo That is just not how idiomatic linux packaging should work. Dependencies (also build dependencies) should be handled by the system package manager instead of git clones.