search

CeaneC / FoundryVTT-Talent

Character sheet support for the Talent class from MCDM's The Talent and Psionics supplement for D&D 5e
1 stars 1 forks source link

[BUG] Cannot Long Rest #18

Open ItsDrafty opened 5 months ago

ItsDrafty commented 5 months ago

Hello!

My group noticed we cannot long rest. I looked into it and with only this module installed, long rests don't work. I get the following error:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'max') at actor.mjs:2505:84 at Array.forEach () at Actor5e._getRestSpellRecovery (actor.mjs:2497:56) at Actor5e._rest (actor.mjs:2322:17) at Actor5e.longRest (actor.mjs:2270:17)

I think it might just be a v12 thing? But I am not totally sure.

Foundry v12 D&D 5e 3.2.1

KJTailor commented 4 months ago

I had this module turned off and couldn't remember what issue made me do that, but now that I had a Talent player again and turned it back on, I can +1 this, I have the same issue

CeaneC commented 3 months ago

Yeah, looks like it's due to another update to the system. I think the numerous workarounds I've had to do to get psionics to behave as a spellcasting progression have caught up with me. JPMeehan has a fork of this module called Talent Psionics which makes powers their own item type, so the module shouldn't be as fragile as mine.

KJTailor commented 3 months ago

I am using that already, thanks for the suggestion though. What I am most interested in is the strain table really. Do you have any good idea how to still incorporate that?

CeaneC commented 3 months ago

Since it's forked off of this one, it should have my strain table included in it

KJTailor commented 3 months ago

I completely missed that that module does more than just create the psionic power items, hahaha

Leona-OzWItch commented 1 month ago

I've narrowed down the source of the issue. I am using Foundry V11, and still had the issue with not being able to long rest. The issue is present in the other module, Talent Psionics, as well. I went through the previous versions of your module, the issue pops up in 1.3.2, but long rests work just fine in 1.3.1, so something in 1.3.2 might be causing it?

I hope this is helpful! Thank you for creating such amazing content!

jilesley commented 4 days ago

If anyone is still having this issue I managed to resolve it by removing upcast: true from CONFIG.DND5E.spellPreparationModes.talent. The line in question; https://github.com/CeaneC/FoundryVTT-Talent/blob/a9b27567af1b8ff25ee64f8cc6657adbbbb6152d/scripts/module.js#L131