CenterForDigitalHumanities / SpectralRTI_Toolkit

Process Spectral RTI Images in ImageJ
GNU General Public License v3.0
1 stars 0 forks source link

No need to create empty folders #90

Closed thanneken closed 5 years ago

thanneken commented 5 years ago

The plugin is creating folders named PCA and Captures-Transmissive-Gamma. I'm not sure there is ever a use case in which those folders would need to be automatically generated if they did not already exist (they are both input into the plugin, not output). I suspect the folder creation was added to prevent a fail elsewhere, but a check on "if directory exists" would be more elegant.

thehabes commented 5 years ago

OK, it will no longer create these by default. A peek at the refactor shows this should not cause null pointers down the line.

thanneken commented 5 years ago

Checked, confirmed