Closed jonathon-love closed 7 years ago
Thanks @jonathon-love! We'll be reviewing the new MFR renderers in the near future and will take a look at this. One thing, could you add a README with some information about the jamovi format? Purpose, what software uses it, links to a spec (if available), that sort of thing. It's helpful when dealing with more specialized file types. Also, you'll need to add an extension => renderer mapping to setup.py
, so that MFR will know how to handle jamovi files.
Cheers, @felliott
hi @felliott,
can you give me a bit more information about the README. i was hoping there would be an extension with a README which i could use as a model, but none of the existing extensions seem to provide one.
i'll do my best to put one together
with thanks
Hey @jonathon-love! What you have there is perfect. I just want a guide for newer and less-common file formats, to help orient new devs. Thanks!
@jonathon-love Can you also add [SVCS-549]
in front of the title of the PR? Thanks.
OK, should be good to go
After fixing the javascript in attributes issue, this is good to go.
OK, is there anything else you're waiting on, or is this in the queue?
with thanks
It's in the queue, should be merged within the next week.
Looks good, merging.
great! how long does it typically take to go live at osf.io?
with thanks
Hey @jonathon-love,
I'm not entirely sure. Normally it would be pretty fast, but we've got a holiday week coming up here in the states that making planning tricky. I'll ping here when I've got an estimate.
Cheers, Fitz
sooooo, still no estimate?
with thanks
Nope! We've only got two tickets left to QA, but our QA interns are gone for the holidays. It should be soon after the next OSF release, so keep an eye out for that.
Hey @jonathon-love,
Sorry for forgetting to update you! Your jamovi-rendering PR was included in MFR v0.23 and released on 2018-01-19.
Cheers, Fitz
awesome! thanks very much!
jonathon
although, i'm not having heaps of success. hopefully just a temporary outage of some sort.
Huh. That's no good. I'll take a look.
The renderer is looking for a file called 01%20anova/resources/7248b84f2576b751.png
in the zip archive. How is the top-level folder encoded if you unzip the archive?
$ unzip -l ping.omv
Archive: ping.omv
Length Date Time Name
--------- ---------- ----- ----
14167 11-15-2017 08:28 index.html
97 11-15-2017 08:28 META-INF/MANIFEST.MF
1257 11-15-2017 08:28 metadata.json
422 11-15-2017 08:28 xdata.json
4836 11-15-2017 08:28 data.bin
6529 11-15-2017 08:28 01 anova/analysis
0 11-15-2017 08:27 ./
36376 11-15-2017 08:28 01 anova/resources/7248b84f2576b751.png
--------- -------
63684 8 files
i'm looking into it (just figuring out how to run mfr locally again, been a while).
chuckles, this is my cock-up. any jamovi files with images in them won't work :/
will have a PR for you shortly.
hi,
[from a code review perspective] this is more or less the same as the jasp renderer (which i also wrote). both the .jasp and the .omv file formats are very similar (again, both designed by me), however, we are expecting the jamovi file format to diverge from the .jasp format in the future -- which is why i haven't elected to unify them.
with thanks