CenterForOpenScience / modular-file-renderer

A Python package for rendering files to HTML via an embeddable iframe
http://modular-file-renderer.readthedocs.io/en/latest/
Apache License 2.0
44 stars 67 forks source link

[SVCS-566]Use CSS spinner over deprecated one #293

Closed AddisonSchiller closed 6 years ago

AddisonSchiller commented 7 years ago

Ticket

https://openscience.atlassian.net/browse/SVCS-566

Purpose

Get rid of old loading spinner

Changes

replaced old spinner with new pure css osf-style spinner

Side effects

None

QA Notes

Deployment Notes

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 63.828% when pulling e9470da965f667cd3b61dea27c03b20972bcc242 on AddisonSchiller:feature/spinner-change into d6f20ba6170965634f915d53491cbb8e9876a79a on CenterForOpenScience:develop.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 63.828% when pulling 7cffbfb108a0dd0029072b2b02f3bf4cd7ef0406 on AddisonSchiller:feature/spinner-change into d6f20ba6170965634f915d53491cbb8e9876a79a on CenterForOpenScience:develop.

felliott commented 7 years ago

Looks good, moving to RTM.