[][SVCS-683] Add timeouts for subprocess calls

CenterForOpenScience / modular-file-renderer

A Python package for rendering files to HTML via an embeddable iframe

http://modular-file-renderer.readthedocs.io/en/latest/

Apache License 2.0

43 stars 67 forks source link

[][SVCS-683] Add timeouts for subprocess calls #332

Closed NyanHelsing closed 5 years ago

NyanHelsing commented 6 years ago

Ticket

SVCS-683 Add timeouts for subprocess calls

Purpose

Make subprocess time out instead of hanging indefinitely.

Changes

Side effects

May make files that are particularly large time out if they take too long.

QA Notes

Deployment Notes

Adds a couple of ENV vars to configure the timeout if desired. Default set to 10s.

coveralls commented 6 years ago

Coverage decreased (-0.3%) to 70.77% when pulling 3f230c2cc036aa6009a5e4051ff55c3c477f448f on birdbrained:ft/add-subproc-to into 7304d3b8e103008377c9fa9781d653b14fa29ade on CenterForOpenScience:develop.

NyanHelsing commented 6 years ago

Needs a rebase