fixed_hc expects two positional arguments but only one is passed

CenterForTheBuiltEnvironment / pythermalcomfort

Package to calculate several thermal comfort indices (e.g. PMV, PPD, SET, adaptive) and convert physical variables.

https://pythermalcomfort.readthedocs.io/en/latest/

MIT License

147 stars 52 forks source link

fixed_hc expects two positional arguments but only one is passed #54

Closed FedericoTartarini closed 1 year ago

FedericoTartarini commented 1 year ago

https://github.com/CenterForTheBuiltEnvironment/pythermalcomfort/blob/c847e76471ad6c02548bc2d6458b6b50b51dd098/src/pythermalcomfort/jos3_functions/thermoregulation.py#L435

AkihisaNomoto commented 1 year ago

Both arguments (hc and v) are used in this function.

AkihisaNomoto commented 1 year ago

Sorry I misunderstood. You are right, and I deleted this function before since this _heat_resistances function is not directly used to JOS3 class with bad commit comment.

FedericoTartarini commented 1 year ago

Okay great if you have fixed this issue I will close the issue.