search

CenterForTheBuiltEnvironment / pythermalcomfort

Package to calculate several thermal comfort indices (e.g. PMV, PPD, SET, adaptive) and convert physical variables.
https://pythermalcomfort.readthedocs.io/en/latest/
MIT License
147 stars 52 forks source link

Limit inputs functions #99

Open FedericoTartarini opened 9 months ago

FedericoTartarini commented 9 months ago

Describe the bug Currently many of the functions accept kwargs as input but this is not great since if a person misspell the input variable then Python does not return an error. See discussion #98

To Reproduce Steps to reproduce the behavior:

  1. pass input stand='ashrae' to pmv
  2. No error is thrown but the the function uses the ISO model to calculate the output.

Expected behavior An error message should be returned

FedericoTartarini commented 9 months ago

I partially started solving this with the commit I did on the 22nd of Feb, but I did not removed kwarg from all the functions