Centias / BankItems

Keep track of you inventory, bank, reagant bank, void storage and more across all your characters. Fork of the original BankItems on Curse/WowAce. Credit to XinHuan/Burstroc and anyone else who worked on the original.
26 stars 2 forks source link

strange behavior with item qualities for ore #14

Closed Kimab closed 1 year ago

Kimab commented 1 year ago

hey there, i just noticed and i dont know how long its happening. here are some pictures: all tested with and without addons beside bankitems. and approved by my sister, she got this too

image thats for serevite ore, mouse on tier 2

image and thats for serevite or, mouse on tier 3

thats also happening for draconium ore but NOT for khazgorite ore tested it for herbs and leather too, it seems they work completely fine

let me know if you need more info

cheers

Kimab commented 1 year ago

i also get 11x BankItems/BankItems.lua:4361: attempt to index local 'theBag' (a nil value) while making crafting order stuff

Centias commented 1 year ago

I don't really know the how or the why, but for some reason all of the item IDs for ore got shuffled around. They used to all be logically right next to each other in sequence, like 123450 -> 123451 -> 123452 (not the actual IDs) but now they all got shuffled around, breaking the logic I had used.

Serevite Ore rank 1 - 190395 Serevite Ore rank 2 - 190396 (at least these two stayed in order, so they still play nice together) Serevite Ore rank 3 - 190394 ( ???? I have no idea why this suddenly got moved to below the other two )

Draconium Ore rank 1 - 189143 Draconium Ore rank 2 - 188658 Draconium Ore rank 3 - 190311 These 3 make no sense, they're all over the place.

Khaz'gorite Ore all stays in order like herbs and leather do, as expected : 190312 -> 190313 -> 190314

I'll see if I can get this sorted out over the weekend, because clearly my logic isn't working right now for just these weird cases.

For the second bug, any further detail would be helpful. I haven't seen it happen, but I may have just missed it hiding in BugSack.

Kimab commented 1 year ago

Take your time! i noticed the strange IDs also, but i thought they were the original one. crazy stuff... idk what further details i can provide - it happens sometimes, not always. i will look out in which situations exactly it happens and provide all i can get to you thanks again and please; take your time! its not like something isnt working at all :)

Kimab commented 1 year ago

34x BankItems/BankItems.lua:4361: attempt to index local 'theBag' (a nil value) just happened again - was making a personal order for my sister for an Empty Soul Cage at the forbidden isle npc but i know this error happens in valdrakken too duration 2 days, 1 silver commission i then tried disabling addons but the error didnt occured a second time :/ even with all addons activated it didnt

and again, sitting on tailoring station in valdrakken, crafting Vibrant Polishing Cloth for the first time, recieving the bonus and got a strange (visual at least) inspiration proc image as you can see, the knowledge seems to have gotten an uprank. the item itself cant get to rank 3, even with inspiration proc. bag was open and crafting window was filtered to items with first time bonus. you think its caused by GW2UI i am using?

Centias commented 1 year ago

Here's something I managed to throw together tonight that should fix the ore situation. Give it a try and if that part seems to be in order I'll get an update put together with it.

BankItems.zip

I still have no idea about the error because I haven't caught the error myself. I tried intentionally sending myself a crafting order with none of the reagents included, then left all my material in the bank thinking maybe it had something to do with trying to update the bank, but got no error.

I think the quality icon showing up on random things is actually just a problem in the game. It seems to happen with my mail a lot.

Kimab commented 1 year ago

thanks for your work! i tried the file and it works the same; serevite is 1&2 together, 3 solo and draconium are all 3 solo. the error is not much to worry about... bugsack catches an error, but everything works totally fine.

tell me if i can help more :)

Centias commented 1 year ago

Hmm, not sure why it's working for me but not for you then. image

Draconium has 2 & 3 together, I actually just don't have any 1's right now. image

Centias commented 1 year ago

I'm possibly an idiot and just realized I basically came up with a solution that only works for English, and you posted an image with item names in another language. I'll have to figure out how I can adapt it across languages or something.

Kimab commented 1 year ago

hehehe sorry for that much work... but there is no other addon that works like BI in terms of qualities. its so handy you see all qualities in one view thanks and take your time :)

Centias commented 1 year ago

Take 2, I think this should work regardless of language : BankItems.zip

Kimab commented 1 year ago

take 2 works flawless =) thank you SO much! i missed that a lot. thousand thanks <3